Skip to content

Qa/rip singer from tests #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

Qa/rip singer from tests #44

wants to merge 49 commits into from

Conversation

@kspeer825
Copy link
Contributor

Description of change

The tests are double logging due to singer deps. Ripped.

Manual QA steps

Risks

Rollback steps

  • revert this branch

prijendev and others added 29 commits May 18, 2022 20:57
@prijendev
Initial commit for expression attributes
d62530c
@prijendev
Updated circleci and full_table.py
9a18c82
@prijendev
resolved pylint error
f5027fe
@prijendev
Updated circleci
6b9bae6
@prijendev
Updated unittest case path in circleci
1376687
@prijendev
Updated expression attribute
a1fd3af
@prijendev
resolved pylint error
ea524af
@prijendev
Updated prepare exprssion logic
d4f6c77
@prijendev
Handled empty projection
242403f
@namrata270998
added logic for nested expressions
9d488f3
@namrata270998
added in log_based test and comments
68c74d6
@namrata270998
added code comments
6e9832a
@prijendev
Updated comments
144098d
@prijendev
Resolved review comments
a643e03
@namrata270998
added comment
fc58a17
@namrata270998
resolved comments
efacad2
@namrata270998
resolved pylint errors
c7c7078
@namrata270998
updated config.yml and a typo
675adb4
@namrata270998
resolved slack-on-notify failure
e5f0089
@namrata270998
removed scenarios
1e198db
@namrata270998
Changed the expressionattribute logic as suggested
d923847
@namrata270998
resolved pylint error
71ebc06
@namrata270998
fixed typo
5a97ba7
@namrata270998
added test case for '.' in fields
2b5199b
@namrata270998
added testcase for prepare_projection()
b319ac1
@namrata270998
resolved comments
b83f6ee
@namrata270998
handled corner case
9bfd082
@namrata270998
added check for empty expression
d9a4cc1
@namrata270998
resolved comments and updated unittests
3a0016c
namrata270998 and others added 20 commits May 18, 2022 20:57
@namrata270998
removed unused import
aa9dc49
@namrata270998
resolved comments
251e400
@namrata270998
fixed pylint failure
0981142
@namrata270998
updated comment
28a64b3
@namrata270998
changed the name of catalog's expression to expression-attributes
8e8d73e
@namrata270998
added tap-tester-user to the config, updated to nosetests
a094a9f
@namrata270998
updated to nosetests
99fd7ee
Changed expression-attributes to expression-attribute
0f08f4b
Changed expression-attributes to expression-attribute
9daad7b
@namrata270998
added tests for primary and replication key reserved words
ec1acdf
@namrata270998
renamed the file
00e119f
@namrata270998
added funciton comments
82d8395
@namrata270998
fixed pylint
b3c148f
expression-attribute -> expression-attributes in full table
d0e6f42
test fixes for pk and hash key as expression-attributes
d3f7b3e
@namrata270998
changed the parameter name to attribute
1f726db
expression-attribute -> expression-attributes in one more test
dc8c579
fix log sync ref and log projection test name
5d2ff51
Changed from attribute to attributes
86e791b
remove singer logger, replace with tt logger
e3be082
@kspeer825 kspeer825 force-pushed the qa/rip-singer-from-tests branch from a57e796 to e3be082 Compare May 18, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kspeer825 @prijendev @namrata270998